-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor border-radius styles to use CSS variable for consistency #2023
Refactor border-radius styles to use CSS variable for consistency #2023
Conversation
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/12828932964/artifacts/2446659085 |
Thank you! I like the consistency but I think the inline styles, such as |
oh my bad i understand now i'll make the change |
assets/css/copy-button.css
Outdated
background-color: transparent; | ||
backdrop-filter: blur(2px); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
background-color: transparent; | |
backdrop-filter: blur(2px); | |
background-color: var(--codeBackground); |
I tried it in a couple places but I found the blurred colors confusing. I did like the border though, can we revert it partially?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josevalim another example zoomed out |
💚 💙 💜 💛 ❤️ |
@hichemfantar, @josevalim, did you mean for the tabs to be affected? Although the tabs are now more visually distinguished from each other, the flatter look feels neater to me. |
Do you prefer the new corner style? Separately to preferring the visual feel of how it was, a (minor) concern I have is that on narrow/mobile screens this approach is more likely to see the tabs taking up more space than is available. Would you be averse to reverting the tabs style? But if you and @josevalim are happy, not to worry. |
I prefer the one with spacing because it gives the elements room to breathe and is more aligned with the theme thanks to the rounded corners. |
I noticed border radius inconsistencies so i addressed them via a single variable.
Update border-radius styles across various components to utilize a CSS variable, ensuring consistency in design. Adjust the variable value for improved appearance.