Implement search preview #1883
Implement search preview #1883
Conversation
| const iframe = document.createElement('iframe') | ||
| const previewHref = elementToSelect.href.replace('.html', '.html?preview=true') | ||
| // The minimum permissions necessary for the iframe to run JavaScript and communicate with the parent window. | ||
| iframe.setAttribute('sandbox', 'allow-scripts allow-same-origin allow-popups allow-forms') |
There was a problem hiding this comment.
Quick question: is there a reason why you add allow-popups and allow-forms?
There was a problem hiding this comment.
IIRC it was necessary for the iframe to render properly, but it was something I set early so we should explore removing it. I think allow-popups was to allow the hover info to work inside of previews.
|
@zachdaniel this looks really good to me! Besides your list of pending actions, something else we need to do is to use "pushMessage" to confirm that a preview is being rendered. Otherwise, we can link to old docs, that will render the whole page rather than a specific preview. You can see how we tackle this in: https://github.com/elixir-lang/ex_doc/blob/main/assets/js/tooltips/hints.js#L99 |
|
@josevalim that makes sense! I wasn't actually sure why that route was chosen, but I understand now. That will also likely solve the iframe height issues, if we just have it push all of its contents and then create an element, it won't have the iframe sizing problems :) |
|
I did a follow up with some refactorings on #1884. Mostly JS left now :D |
Hey all!
I've discussed the ability to preview pages in autocomplete with @josevalim, and this is the groundwork for that feature. There is more to be done, and I hate to be one to throw things over the fence, but with Ash's 3.0 release coming soon, multiple trainings ahead, and various other things on my plate, I just haven't had time to wrap this up and I don't know when I will have time to get back to it. Additionally, this isn't my wheelhouse so it is possible that there are folks who are more familiar w/ making good UIs that could be more effective. Here is a video showing the current behavior:
CleanShot.2024-04-03.at.00.00.16.mp4
And here is what remains to be done:
Again, sorry I haven't had the time lately to get this over the line, but I think it is close enough to open a draft PR, hopefully someone has some cycles to wrap it up! If not, I can come back to it in maybe 4-5 weeks