epub: fix logo not declared in the OPF manifest #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to list all the resources included in the EPUB file in the OPF
manifest, we missed doing that for the logo.
Basically this PR should fix the following error found by `epubcheck`:
```json
{
"ID" : "RSC-008",
"severity" : "ERROR",
"message" : "Referenced resource \"OEBPS/assets/logo.png\" is not declared in the OPF manifest.",
"locations" : [ {
"path" : "OEBPS/title.xhtml",
"line" : 21,
"column" : 55
} ]
}
```
I also some small refactor in this template.
|
Could we add a test for this one? :) |
Sure, now it's done. |
josevalim
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to list all the resources included in the EPUB file in the OPF manifest, we missed doing that for the logo.
Basically this PR fix the following error found by
epubcheck:{ "ID" : "RSC-008", "severity" : "ERROR", "message" : "Referenced resource \"OEBPS/assets/logo.png\" is not declared in the OPF manifest.", "locations" : [ { "path" : "OEBPS/title.xhtml", "line" : 21, "column" : 55 } ] }I also did some small refactor in this template.