Prevent subsequent v press from submitting form

elixir-lang · Jun 10, 2024 · 98a6856 · 98a6856
1 parent ee6ccb3
commit 98a6856
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/assets/js/keyboard-shortcuts.js b/assets/js/keyboard-shortcuts.js
@@ -74,7 +74,7 @@ function addEventListeners () {
 
 function handleKeyDown (event) {
   if (state.shortcutBeingPressed) { return }
-  if (event.target.matches('input, textarea')) { return }
+  if (event.target.matches('input, select, textarea')) { return }
 
   const matchingShortcut = keyboardShortcuts.find(shortcut => {
     if (shortcut.hasModifier) {

diff --git a/assets/js/sidebar/sidebar-version-select.js b/assets/js/sidebar/sidebar-version-select.js
@@ -83,6 +83,14 @@ export function openVersionSelect () {
   if (select) {
     select.focus()
 
+    // Prevent subsequent 'v' press from submitting form
+    select.addEventListener('keydown', event => {
+      if (event.key === 'Escape' || event.key === 'v') {
+        event.preventDefault()
+        select.blur()
+      }
+    })
+
     if (navigator.userActivation.isActive && 'showPicker' in HTMLSelectElement.prototype) {
       select.showPicker()
     }