Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add examples to exception.ex for clearer error handling #14227

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Feat: Add examples to exception.ex for clearer error handling #14227

merged 5 commits into from
Jan 27, 2025

Conversation

bennydreamtech23
Copy link
Contributor

  1. Adds example to the module with only an explanation but no example, to see how the error is caused.
  2. Some module in exception do not have description for example: UnicodeConversionError module
  3. These changes was added to enrich the documentation to assist developers understand how the exception are raised.

@josevalim
Copy link
Member

Thank you, beautiful work. I have pushed some improvements and I will merge it once CI passes.

krns
krns reviewed Jan 27, 2025
View reviewed changes
lib/elixir/lib/exception.ex Outdated Show resolved Hide resolved
@josevalim josevalim merged commit 1eb3a20 into elixir-lang:main Jan 27, 2025
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@bennydreamtech23
Copy link
Contributor Author

Thank you for the support and I am so happy 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim left review comments

@krns krns krns left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bennydreamtech23 @josevalim @krns