Support negative period prefix in Calendar.ISO.parse_duration/1
#13608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfiedlerdejanze
changed the title
Calendar.ISO.parse_duration/1
josevalim
reviewed
May 27, 2024
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
May 27, 2024
|
@josevalim given the links i posted in the PR description, would you be open to also allowing |
|
Yes, we should definitely support the plus version too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative durations are actually specified in ISO 8601-2 while individual negative units are not. The Java Duration class supports both features and i think the negative duration prefix may actually be more common than the one for individual units. IMHO it makes sense that we also support both in the standard library.