Keep position meta on & capture special variables in expanded AST #13607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszsamson
commented
May 27, 2024
| @@ -1133,6 +1133,12 @@ defmodule Kernel.ExpansionTest do | |||
| assert expand(quote(do: &unknown(&1, &2))) == {:&, [], [{:/, [], [{:unknown, [], nil}, 2]}]} | |||
| end | |||
|
|
|||
| test "keeps position meta on & variables" do | |||
| assert expand(Code.string_to_quoted!("& &1")) == | |||
| {:fn, [{:line, 1}], | |||
There was a problem hiding this comment.
I'm not sure meta on fn and -> makes sense
lukaszsamson
commented
May 27, 2024
lib/elixir/src/elixir_fn.erl
Outdated
| Var = {list_to_atom([$& | integer_to_list(Pos)]), [], nil}, | ||
| {Var, orddict:store(Pos, Var, Dict)}; | ||
| Var = {list_to_atom([$& | integer_to_list(Pos)]), Meta, nil}, | ||
| {Var, orddict:store(Pos, setelement(2, Var, []), Dict)}; |
There was a problem hiding this comment.
I didn't add meta on the left arg of -> as that node is not present in the code
There was a problem hiding this comment.
I would keep it on both sides, the more information, potentially the better?
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
&variables exist in the code so it makes sense to preserve the position in expansion