Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Andrea Leopardi <[email protected]>
  • Loading branch information
josevalim and whatyouhide authored May 29, 2024
1 parent d91f6b7 commit b041556
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions lib/ex_unit/lib/ex_unit/case.ex
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ defmodule ExUnit.Case do
For example, Elixir has a module called `Registry`, which can have type
`:unique` or `:duplicate`, and can control its concurrency factor using
the `:partitions` option. If you have a number of tests that *behave the
same* across all of those values, I can parameterize those tests with:
same* across all of those values, you can parameterize those tests with:
setup_all do
parameters =
Expand All @@ -252,12 +252,12 @@ defmodule ExUnit.Case do
Use parameterized tests with care:
* Abuse of parameterized tests may make your test suite considerably slower
* Abuse of parameterized tests may make your test suite considerably slower
* If you use parameterized tests and then find yourself adding conditionals
in your tests to deal with different parameters, then parameterized tests
may be the wrong solution to your problem. Consider creating separated
tests and sharing logic between them using regular functions
* If you use parameterized tests and then find yourself adding conditionals
in your tests to deal with different parameters, then parameterized tests
may be the wrong solution to your problem. Consider creating separated
tests and sharing logic between them using regular functions
## Log Capture
Expand Down

0 comments on commit b041556

Please sign in to comment.