Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Arrow IPC Stream files #270

Merged
merged 5 commits into from
Oct 27, 2022
Merged

Add support for Arrow IPC Stream files #270

merged 5 commits into from
Oct 27, 2022

Conversation

joshuataylor
Copy link
Contributor

@joshuataylor joshuataylor commented Jun 24, 2022 •
edited
Loading

This is waiting on pola-rs/polars#3783 being merged, once it is we can remove the reference to my repository, and just use the Polars version with this.

Closes #265

@joshuataylor
Copy link
Contributor Author

joshuataylor commented Jun 25, 2022 •
edited
Loading

This is now merged in Polars, so we wait for this to be released as a minor version in Polars. 🎉

@josevalim
Copy link
Member

Congratulations on shipping this upstream!

@cigrainger
Copy link
Member

Congrats @joshuataylor! Great stuff. 🎉

@joshuataylor joshuataylor mentioned this pull request Aug 5, 2022
Merged
@joshuataylor joshuataylor changed the title [WIP] Add support for Arrow IPC Stream files Add support for Arrow IPC Stream files Aug 6, 2022
@josevalim
Copy link
Member

@joshuataylor can you please rebase? I think you can pretty much discard your changes to expressions.rs and we should be good to go!

@joshuataylor
Copy link
Contributor Author

👀

@joshuataylor joshuataylor force-pushed the feature/polars-ipc-streaming-reader branch from 338d024 to 26319f8 Compare September 15, 2022 02:38
@joshuataylor joshuataylor marked this pull request as ready for review September 15, 2022 02:39
philss
philss approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@philss philss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 🚀

@philss philss merged commit 7f0c887 into elixir-explorer:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim left review comments

@philss philss philss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add df_read_ipc_stream
4 participants
@joshuataylor @josevalim @cigrainger @philss