Convert Enum.map/2+Enum.join/2 to Enum.map_join/3 #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/mix/tasks/ecto.load.ex
Outdated
| @@ -101,7 +101,7 @@ defmodule Mix.Tasks.Ecto.Load do | |||
| end | |||
|
|
|||
| defp skip_safety_warnings? do | |||
| Mix.Project.config()[:start_permanent] != true | |||
| not Mix.Project.config()[:start_permanent] | |||
There was a problem hiding this comment.
this will raise instead of returning true if start_permanent is not a boolean. i don't believe there is a reason to change this behaviour
lib/ecto/migration.ex
Outdated
| @@ -1540,7 +1539,7 @@ defmodule Ecto.Migration do | |||
| end | |||
|
|
|||
| defp validate_index_opts!(opts) when is_list(opts) do | |||
| if opts[:nulls_distinct] != nil and opts[:unique] != true do | |||
| if opts[:nulls_distinct] != nil and not opts[:unique] do | |||
warmwaffles
reviewed
Jan 8, 2024
lib/ecto/migration.ex
Outdated
| @@ -944,8 +944,7 @@ defmodule Ecto.Migration do | |||
| |> List.flatten() | |||
| |> Enum.map(&to_string(&1)) | |||
| |> Enum.map(&String.replace(&1, ~r"[^\w_]", "_")) | |||
| |> Enum.map(&String.replace_trailing(&1, "_", "")) | |||
| |> Enum.join("_") | |||
| |> Enum.map_join("_", &String.replace_trailing(&1, "_", "")) | |||
There was a problem hiding this comment.
You should lift this change to a separate PR and if you are going for efficiency, you might as well combine the previous map functions into one anonymous function.
There was a problem hiding this comment.
Thanks for the feedback! That's a big improvement over what I did initially.
|
We will gladly accept the map_join ones, but we should not change the boolean ones. :) Thank you! |
|
Alright I've got that updated. Let me know if you need anything else. Thanks! |
josevalim
changed the title
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored from " != true"to use "not" for 2 boolean variables
Refactored Enum.map |> Enum.join to Enum.map_join