Dongle dunkey #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct fibonacci
…-101 into DongleDunkey
eliastor
reviewed
Oct 31, 2022
unit1/exercises/e3/main.go
Outdated
| type ErrNegativeSqrt float64 | ||
|
|
||
| func (e ErrNegativeSqrt) Error() string { | ||
| return fmt.Sprintln("cannot Sqrt negative number: -2") |
There was a problem hiding this comment.
There must be no new line in such functions, only one line string. Also the actual number must be returned instead of hardcoded value.
fmt.Sprintf is the best option here
There was a problem hiding this comment.
Correct it on 1ecacf5
As a part of this exercise, I found myself with the cast :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.