Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: custom keywords on complex types #8

Merged
merged 2 commits into from
Apr 25, 2024
Merged

fix: custom keywords on complex types #8

merged 2 commits into from
Apr 25, 2024

Conversation

GeekyEggo
Copy link
Member

@GeekyEggo GeekyEggo commented Apr 24, 2024 •
edited
Loading

When versioning manifests, the custom schema keywords, for example @filePath were not being carried forward on utility types.

  • Remove utility types.
  • Refactor custom keywords to reside on the property signatures.
  • Improve test coverage.

@GeekyEggo
fix: custom keywords on complex types
ad0d498 
When versioning manifests, the custom schema keywords, for example @filepath were not being carried forward on utility types.
@GeekyEggo GeekyEggo requested a review from Elgato-AStory April 24, 2024 19:22
@GeekyEggo GeekyEggo merged commit 44f6d76 into main Apr 25, 2024
1 check passed
@GeekyEggo GeekyEggo deleted the patterns branch April 25, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elgato-AStory Elgato-AStory Elgato-AStory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeekyEggo @Elgato-AStory