Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicator.css: Add a background pulse to non-muted mic #106

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

danirabbit
Copy link
Member

A little more eye-catching and "active" feeling

@danirabbit danirabbit requested a review from cassidyjames July 24, 2019 17:09
@cassidyjames
Copy link
Contributor

Hm, I'm not sure. I don't know if I want system UI pulsing for more than a moment: it means the GPU is constantly doing work, invalidating the pixel cache, and not able to go into a lower power state. Though to be honest I'd have to ask a GTK expert what the real draw of that would be (or do some testing).

I also don't know that I like the design; it doesn't work on a blue background at all and the oval doesn't quite fit in with the other indicators to me. Would it make sense to just have the mic itself constantly blue (so we get the shadow protecting the contrast a bit), kind of like how we have the muted speaker notification orange/yellow? Or even just pulsing less constantly, like once every few seconds?

Copy link
Contributor

@cassidyjames cassidyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the previous comment. I like the concept, but I don't think I like the design; the shape and color feel weird to me. I think red could make sense since it's associated with recording, and maybe a dot like the notifications would be simple enough to convey the same information.

@jeremypw jeremypw marked this pull request as draft June 22, 2021 16:59
@jeremypw
Copy link
Collaborator

Converting to draft as there are unresolved design issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants