Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a volume control #367

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add a volume control #367

wants to merge 4 commits into from

Conversation

leolost2605
Copy link
Member

Fixes #51

Allows adjusting volume of currently playing video.

Because of the action bar the space on the left looks a bit weird currently but that's fixed with #362

@leolost2605 leolost2605 requested a review from a team August 24, 2023 11:14
@danirabbit
Copy link
Member

I'm kind of more inclined to go the route of per-app volume controls in the sound indicator/settings so that we're not duplicating sound UI everywhere. Having sound controls in the app means a situation where you may be unable to hear audio even though controls are showing full volume. Having all the volume controls together would make sure it's obvious when the total system sound is lowered and we can be smarter about maybe only showing several volume controls when several sound sources are available etc

@leolost2605
Copy link
Member Author

For some reason the gstreamer reported volume is actually synchronized with the pulseaudio per application volume in the settings, no idea why though 😅
It might be useful to have a more convenient way to access the same setting for this app here but we can keep it without too (although then I would really like to have the setting accessible through the indicator).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Player is missing volume control
2 participants