Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load sidebar folder children asynchronously after docs finished loading #1522

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jan 28, 2025

Fixes #1332

  • Loading of docs now async
  • Loading of sidebar folder children now async
  • Sidebar folder only expanded after docs finish loading.

A consequence of this is that documents are restored sequentially in order to more easily determine when they have all loaded. Tests with multiple large text files (10,000 lines) indicate that this is unlikely to be significant in practice.

@jeremypw jeremypw changed the title Load children asynchronously Load sidebar folder children asynchronously after docs finished loading Jan 28, 2025
@jeremypw jeremypw marked this pull request as ready for review January 28, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar is slow to expand folders containing moderately many (2000) files first time
1 participant