Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PreferencesDialog: rewrite #1449

Merged
merged 3 commits into from
Jul 12, 2024
Merged

PreferencesDialog: rewrite #1449

merged 3 commits into from
Jul 12, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jul 11, 2024 •
edited
Loading

  • More modern justified layout
  • Make sure all switches are screen reader accessible
  • Double space between sections
  • Show description text without needing to hover
  • Small min-width, more resizable
  • Can't subclass Label in GTK4

Screenshot from 2024-07-11 12 51 33
Screenshot from 2024-07-11 12 51 37
Screenshot from 2024-07-11 12 51 40

@danirabbit danirabbit requested a review from a team July 11, 2024 19:56
@danirabbit danirabbit enabled auto-merge (squash) July 12, 2024 15:04
@danirabbit danirabbit merged commit 50bf489 into master Jul 12, 2024
6 checks passed
@danirabbit danirabbit deleted the danirabbit/preferences-rewrite branch July 12, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tintou tintou tintou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A11y
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @tintou