Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create io.github.leolost2605.detective.json #518

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Jun 27, 2024

FWIW once wingpanel is ported to gtk4 a lot of the stuff from this codebase can be used there in the applications menu for some additional features like proper file search :)

Review Checklist

  • App opens
  • Does what it says
  • Categories match

AppData

  • Name is unique and non-confusing
  • Matches description
  • Matches screenshot
  • Launchable tag with matching ID
  • Release tag with matching version and YYYY-MM-DD date
  • Custom colors meet WCAG A contrast or greater
  • OARS info matches

Flatpak

  • Uses elementary runtime
  • Sandbox permissions are reasonable

@leolost2605 leolost2605 requested a review from a team as a code owner June 27, 2024 11:33
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is messed up in your screenshots. They should have a transparent background with a shadow but they have a black background and look unevenly cropped 😬 https://github.com/leolost2605/detective/blob/488ca501f7645baceb5dfd145ea3b506673878f9/data/screenshots/Main.png

This app asks for some pretty expansive sandbox permissions. I would recommend adding something to your metainfo about why these permissions are needed. As is there will be a lot of warnings on your app info page but no explanation of how these permissions are used by your app

@leolost2605
Copy link
Member Author

I just saw elementary/gala#1957 so the screenshots should be fixed now 😅

Also I added a passage explaining why advanced permissions are required to the description.

@leolost2605 leolost2605 requested a review from danirabbit June 27, 2024 16:11
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New screenshots look good!

I'm sorry I should have noticed this before, but the screenshot URLs are pointing to the github webpage of the screenshot and not the file itself. So for example:

https://github.com/leolost2605/detective/blob/d7511080d724dd81fdb430c0bde9d7748654dec5/data/screenshots/Main.png

should be

https://raw.githubusercontent.com/leolost2605/detective/d7511080d724dd81fdb430c0bde9d7748654dec5/data/screenshots/Main.png

Or you can use the tag instead of the commit hash:

https://raw.githubusercontent.com/leolost2605/detective/1.0.1/data/screenshots/Main.png

@leolost2605
Copy link
Member Author

leolost2605 commented Jun 28, 2024

Oops should be fixed now :)

@leolost2605 leolost2605 requested a review from danirabbit June 28, 2024 08:48
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 🎉

@danirabbit danirabbit merged commit e030703 into elementary:main Jun 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants