Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an error if someone is using an incorrect suffix in a config duration string #18112

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Jan 28, 2025

Raise an error if someone is using an incorrect suffix in a config duration string.

Previously, a value like 5q would be interpreted as 5 milliseconds. We should just raise an error instead of letting someone run with a misconfiguration.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you'll add a reasonable changelog.

@MadLittleMods MadLittleMods marked this pull request as ready for review January 30, 2025 00:13
@MadLittleMods MadLittleMods requested a review from a team as a code owner January 30, 2025 00:13
@MadLittleMods MadLittleMods merged commit a0b7047 into develop Jan 30, 2025
39 checks passed
@MadLittleMods MadLittleMods deleted the madlittlemods/incorrect-suffix-parse_duration branch January 30, 2025 00:14
@MadLittleMods
Copy link
Contributor Author

Thanks for the review @anoadragon453 🦜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants