Speedup the building of Docker images #18038
Conversation
|
|
||
| ENV UV_LINK_MODE=copy |
There was a problem hiding this comment.
Could you leave a comment explaining why this is useful?
There was a problem hiding this comment.
From https://github.com/astral-sh/uv/blob/main/docs/guides/integration/docker.md#caching:
Changing the default UV_LINK_MODE silences warnings about not being able to use hard links since the cache and sync target are on separate file systems.
docker/Dockerfile
Outdated
| xmlsec1:${arch} \ | ||
| libjemalloc2:${arch} \ | ||
| libicu72:${arch} \ | ||
| openssl:${arch} || exit 10; \ |
There was a problem hiding this comment.
Why exit 10? Is the exit code returned by apt-get download in case of failure not appropriate?
| mkdir -p /install-${arch}/var/lib/dpkg/status.d/ && \ | ||
| for deb in /tmp/debs-${arch}/*.deb; do \ | ||
| package_name=$(dpkg-deb -I ${deb} | awk '/^ Package: .*$/ {print $2}'); \ | ||
| echo "Process: ${package_name}"; \ |
There was a problem hiding this comment.
| echo "Process: ${package_name}"; \ | |
| echo "Extracting: ${package_name}"; \ |
| @@ -78,38 +49,20 @@ ARG TEST_ONLY_IGNORE_POETRY_LOCKFILE | |||
| # Export the dependencies, but only if we're actually going to use the Poetry lockfile. | |||
| # Otherwise, just create an empty requirements file so that the Dockerfile can | |||
| # proceed. | |||
| RUN if [ -z "$TEST_ONLY_IGNORE_POETRY_LOCKFILE" ]; then \ | |||
| /root/.local/bin/poetry export --extras all -o /synapse/requirements.txt ${TEST_ONLY_SKIP_DEP_HASH_VERIFICATION:+--without-hashes}; \ | |||
| ARG POETRY_VERSION | |||
There was a problem hiding this comment.
Nitpick: set this here instead of in the global scope, since no other build stage uses it.
|
|
||
| ENV UV_LINK_MODE=copy |
There was a problem hiding this comment.
From https://github.com/astral-sh/uv/blob/main/docs/guides/integration/docker.md#caching:
Changing the default UV_LINK_MODE silences warnings about not being able to use hard links since the cache and sync target are on separate file systems.
| RUN if [ -z "$TEST_ONLY_IGNORE_POETRY_LOCKFILE" ]; then \ | ||
| /root/.local/bin/poetry export --extras all -o /synapse/requirements.txt ${TEST_ONLY_SKIP_DEP_HASH_VERIFICATION:+--without-hashes}; \ | ||
| ARG POETRY_VERSION | ||
| RUN --mount=type=cache,target=/root/.cache/uv \ |
There was a problem hiding this comment.
Should UV_LINK_MODE=copy be set here as well?
This is a split off #18033
This uses a few tricks to speed up the building of docker images:
uv pip installinstead ofpip install. This saves a bunch of time, especially when cross-compilingapt-get downloadplusdpkg --extract