Room List - Update the room list store on actions from the dispatcher #29397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MidhunSureshR
force-pushed
the
midhun/rls/updates
branch
from
8e30510 to
c2079e1
Compare
MidhunSureshR
force-pushed
the
midhun/rls/room-list-vm-1
branch
from
f9754ea to
a7817e5
Compare
MidhunSureshR
force-pushed
the
midhun/rls/updates
branch
from
23f158a to
35a9cbe
Compare
MidhunSureshR
force-pushed
the
midhun/rls/updates
branch
from
534e3e1 to
9f0f782
Compare
MidhunSureshR
changed the title
- Make if/else more consistent - Add comment on findAndAddRoom()
On a timeline action, we return early if payload.room is falsy. So then why do we need to retry fetching the room? I think this can be removed but will ask others if there's some conext I'm missing.
MidhunSureshR
force-pushed
the
midhun/rls/updates
branch
from
9cd1f3f to
9465811
Compare
florianduros
approved these changes
Mar 3, 2025
Comment on lines
126
to
139
| if (payload.event_type !== EventType.Direct) return; | ||
| const dmMap = payload.event.getContent(); | ||
| for (const userId of Object.keys(dmMap)) { | ||
| const roomIds = dmMap[userId]; | ||
| for (const roomId of roomIds) { | ||
| const room = this.matrixClient.getRoom(roomId); | ||
| if (!room) { | ||
| logger.warn(`${roomId} was found in DMs but the room is not in the store`); | ||
| continue; | ||
| } | ||
| this.addRoomAndEmit(room); | ||
| } | ||
| } | ||
| break; |
There was a problem hiding this comment.
This will fire LISTS_UPDATE_EVENT multiple times. Can we add the rooms to the skip list and after fire once the event?
| } | ||
| } | ||
|
|
||
| private addRoomAndEmit(room: Room): void { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the new room list store so that it listens to actions on the dispatcher and re-inserts the necessary room(s) as necessary. Based on https://github.com/element-hq/element-web/blob/develop/src/stores/room-list/RoomListStore.ts#L183