Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test to ensure that dehydrated device gets removed on identity reset #29354

Merged
merged 1 commit into from
Feb 25, 2025
Merged

add test to ensure that dehydrated device gets removed on identity reset #29354

merged 1 commit into from
Feb 25, 2025

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Feb 25, 2025

Test to make sure that #29131 is fixed

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@uhoreg uhoreg requested a review from a team as a code owner February 25, 2025 01:05
@uhoreg uhoreg requested a review from andybalaam February 25, 2025 01:05
@uhoreg uhoreg force-pushed the playwright_delete_dehydrated_device_on_reset_identity branch from e362567 to ba03868 Compare February 25, 2025 02:03
@uhoreg uhoreg added the T-Task Tasks for the team like planning label Feb 25, 2025
andybalaam
andybalaam approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks!

@uhoreg uhoreg added this pull request to the merge queue Feb 25, 2025
Merged via the queue into element-hq:develop with commit 62a2872 Feb 25, 2025
33 of 34 checks passed
@uhoreg uhoreg deleted the playwright_delete_dehydrated_device_on_reset_identity branch February 25, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uhoreg @andybalaam