Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove boilerplate around dispatcher and settings watchers #28338

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Remove boilerplate around dispatcher and settings watchers #28338

merged 3 commits into from
Nov 1, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Oct 30, 2024 •
edited
Loading

Lots of pointless if statements and typing differences was pretty pointless

@t3chguy t3chguy added the T-Task Tasks for the team like planning label Oct 30, 2024
@t3chguy t3chguy self-assigned this Oct 30, 2024
@t3chguy
Iterate
f980e1c 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy marked this pull request as ready for review October 30, 2024 15:14
@t3chguy t3chguy requested a review from a team as a code owner October 30, 2024 15:14
langleyd
langleyd approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@langleyd langleyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM bar maybe tweaking the documentation

src/settings/SettingsStore.ts Outdated Show resolved Hide resolved
src/dispatcher/dispatcher.ts Outdated Show resolved Hide resolved
@t3chguy
Iterate
522be2d 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy enabled auto-merge November 1, 2024 15:12
@t3chguy t3chguy added this pull request to the merge queue Nov 1, 2024
Merged via the queue into develop with commit 2d9982f Nov 1, 2024
32 checks passed
@t3chguy t3chguy deleted the t3chguy/react18/createRoot.3 branch November 1, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langleyd langleyd langleyd approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from element-hq/element-web-reviewers

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @langleyd