Switch ModalManager to the React 18 createRoot API #28336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
t3chguy
force-pushed
the
t3chguy/react18/createRoot.2
branch
from
96ac305 to
628e3af
Compare
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
t3chguy
requested review from
dbkr and
robintown
and removed request for
a team
dbkr
approved these changes
Oct 31, 2024
t3chguy
force-pushed
the
t3chguy/react18/createRoot.6
branch
from
c016f30 to
4550068
Compare
…to t3chguy/react18/createRoot.2 # Conflicts: # src/async-components/views/dialogs/security/CreateSecretStorageDialog.tsx # src/components/views/rooms/RoomBreadcrumbs.tsx # src/dispatcher/dispatcher.ts # src/settings/SettingsStore.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.