Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI docs generation #27530

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Fix CI docs generation #27530

merged 1 commit into from
Jun 6, 2024

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Jun 6, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Fix https://github.com/element-hq/element-web/actions/runs/9368190448/job/25789587578
Result with the fix https://github.com/element-hq/element-web/actions/runs/9402024104/job/25895123158?pr=27530

The 0.1.16 of mdbook-combiner is messing with the generated path of the SUMMARY.MD.
With the 0.1.15, the path are correctly created in the generated SUMMARY.MD but the 0.1.16 seems to skip this step.

@florianduros florianduros added the T-Task Tasks for the team like planning label Jun 6, 2024
@florianduros florianduros force-pushed the florianduros/fix/ci-docs branch from 7e95c6a to 94cb8bd Compare June 6, 2024 13:44
@florianduros florianduros marked this pull request as ready for review June 6, 2024 13:53
@florianduros florianduros requested a review from a team as a code owner June 6, 2024 13:53
t3chguy
t3chguy approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane otherwise

@florianduros florianduros force-pushed the florianduros/fix/ci-docs branch from 6342c24 to 20ed49b Compare June 6, 2024 14:01
@florianduros florianduros enabled auto-merge June 6, 2024 14:01
@florianduros florianduros force-pushed the florianduros/fix/ci-docs branch from 20ed49b to 2db2cf2 Compare June 6, 2024 14:02
@florianduros florianduros added this pull request to the merge queue Jun 6, 2024
Merged via the queue into develop with commit 0b49a77 Jun 6, 2024
23 checks passed
@florianduros florianduros deleted the florianduros/fix/ci-docs branch June 6, 2024 14:37
@florianduros florianduros mentioned this pull request Jul 2, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-team

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @t3chguy