Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign Docker images using cosign #26817

Merged
merged 2 commits into from
May 13, 2024
Merged

Sign Docker images using cosign #26817

merged 2 commits into from
May 13, 2024

Conversation

gaelgatelement
Copy link
Member

@gaelgatelement gaelgatelement commented Jan 3, 2024 •
edited by github-actions bot
Loading

Here's what your changelog entry will look like:

✨ Features

  • Sign Docker images using cosign (#26817).

@gaelgatelement gaelgatelement requested a review from a team as a code owner January 3, 2024 09:43
@gaelgatelement gaelgatelement requested a review from t3chguy January 3, 2024 09:43
@gaelgatelement gaelgatelement force-pushed the gaelg/sign-images-cosign branch from 12eaa5e to 2b9f9f3 Compare January 3, 2024 09:43
t3chguy
t3chguy requested changes Jan 3, 2024
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide context, or an issue which provides context.

@gaelgatelement
Copy link
Member Author

gaelgatelement commented Jan 3, 2024 •
edited
Loading

Please provide context, or an issue which provides context.

Context : https://github.com/element-hq/sre-internal/issues/2920

@t3chguy t3chguy changed the title sign images using cosign Sign Docker images using cosign Jan 3, 2024
@benbz benbz force-pushed the gaelg/sign-images-cosign branch from 06545a4 to b64d233 Compare May 8, 2024 15:23
@gaelgatelement @benbz
sign images using cosign
7359c9b 
Signed-off-by: Gaël Goinvic <[email protected]>
@benbz benbz force-pushed the gaelg/sign-images-cosign branch from b64d233 to 7359c9b Compare May 8, 2024 15:27
@benbz benbz requested a review from t3chguy May 8, 2024 15:27
t3chguy
t3chguy approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane otherwise

@benbz @t3chguy
Indent inline script correctly
6ebe844 
Co-authored-by: Michael Telatynski <[email protected]>
@benbz benbz added this pull request to the merge queue May 13, 2024
Merged via the queue into develop with commit e651330 May 13, 2024
23 checks passed
@benbz benbz deleted the gaelg/sign-images-cosign branch May 13, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaelgatelement @t3chguy @benbz