Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added private sign off process in contributing.md #26785

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Added private sign off process in contributing.md #26785

merged 1 commit into from
Dec 18, 2023

Conversation

Pankaj-SinghR
Copy link
Contributor

@Pankaj-SinghR Pankaj-SinghR commented Dec 18, 2023 •
edited by github-actions bot
Loading

Notes: Fix a bug (#26654) where the Private sign off process section was missing.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@Pankaj-SinghR Pankaj-SinghR requested a review from a team as a code owner December 18, 2023 14:58
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Dec 18, 2023
robintown
robintown approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for documenting this! This description matches my memory of how the process works, and it's the exact same wording as the one in matrix-spec, so I think everything looks right.

@robintown robintown removed the request for review from t3chguy December 18, 2023 15:40
@robintown robintown added the T-Task Tasks for the team like planning label Dec 18, 2023
@robintown robintown enabled auto-merge (squash) December 18, 2023 15:41
@robintown robintown merged commit 4203c95 into element-hq:develop Dec 18, 2023
25 of 26 checks passed
@robintown robintown mentioned this pull request Dec 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robintown robintown robintown approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pankaj-SinghR @robintown