Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.11.23 #7891

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Release 1.11.23 #7891

merged 4 commits into from
Jan 10, 2025

Conversation

pixlwave
Copy link
Member

This PR prepares the release of Element v1.11.23.

Notes:

  • This PR targets release/1.11.23/master, which has been cut from master.
  • It includes changes to the Podfile, but not the corresponding changes to Podfile.lock, as pod install hasn't yet been run.
    This is because the Podfile targets future versions of dependencies yet to be released, so pod install wouldn't be able to find them yet.
  • When the CI runs its checks, it will temporarily point to the pending release branches of those dependencies beforehand
  • It is only during release:finish that pod update will be run -- updating the Podfile.lock
    to use the now officially released dependencies -- before ultimately merging release/1.11.23/master into master to tag the release.

➡️ Once this PR is merged, you will need to first ensure that the products this one depends on are fully released,
then run bundle exec rake release:finish to close this release.

💡 If you want to review only the changes made since the release branch was cut from develop,
you can check those here

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 60.50955% with 124 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/1.11.23/master@c12e1f3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../AuthenticationServerSelectionViewModelTests.swift 0.00% 25 Missing ⚠️
...nit/AuthenticationRegistrationViewModelTests.swift 0.00% 23 Missing ⚠️
...tor/AuthenticationServerSelectionCoordinator.swift 0.00% 22 Missing ⚠️
...inator/AuthenticationRegistrationCoordinator.swift 0.00% 17 Missing ⚠️
...stration/AuthenticationRegistrationViewModel.swift 33.33% 8 Missing ⚠️
...les/Authentication/AuthenticationCoordinator.swift 0.00% 7 Missing ⚠️
...s/Common/Sunset/SunsetOIDCRegistrationBanner.swift 81.25% 6 Missing ⚠️
...I/Modules/Common/Sunset/SunsetDownloadBanner.swift 87.80% 5 Missing ⚠️
...ction/AuthenticationServerSelectionViewModel.swift 55.55% 4 Missing ⚠️
...s/Authentication/Common/AuthenticationModels.swift 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@                    Coverage Diff                    @@
##             release/1.11.23/master    #7891   +/-   ##
=========================================================
  Coverage                          ?   16.30%           
=========================================================
  Files                             ?     1812           
  Lines                             ?   173859           
  Branches                          ?    67388           
=========================================================
  Hits                              ?    28343           
  Misses                            ?   145474           
  Partials                          ?       42           
Flag Coverage Δ
uitests 62.37% <85.20%> (?)
unittests 9.06% <8.30%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 71b0811 into release/1.11.23/master Jan 10, 2025
7 checks passed
@pixlwave pixlwave deleted the release/1.11.23/release branch January 10, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant