feat: signWithHook supports one-time invocation. #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a parameter:
noIterateFiles
.In my company, a single Windows certificate is used for signing multiple Electron applications, so we want to centralize the signing capability onto one device to save on certificate purchase costs.
Currently, I plan to modify the signing process on each CI (Continuous Integration) device using a
hookFunction
. This involves compressing all DLLs that need to be signed into a ZIP file, uploading it to a dedicated signing machine, downloading the signed artifacts after signing is complete, and completing the remote signing process. This ensures that the signing machine does not need to perform any additional tasks, such as packaging frontend artifacts.However, the original logic of
signWithHooks
would call thehookFunction
multiple times, which would be disastrous in my plan as it would lead to multiple upload and download processes. Therefore, I added a parameter to control this logic. If this parameter is not passed, no one's logic will be affected because it is forward-compatible.Additionally, some parameters causing type errors were removed from the unit test section.