Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up issue templates #3841

Merged
merged 3 commits into from
Feb 8, 2025
Merged

chore: clean up issue templates #3841

merged 3 commits into from
Feb 8, 2025

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Feb 8, 2025

Uses type instead of label for the top-level field. Uses placeholder field where applicable and updates some version numbers.

@erickzhao erickzhao marked this pull request as ready for review February 8, 2025 02:59
@erickzhao erickzhao requested a review from a team as a code owner February 8, 2025 02:59
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should leave the labels for now, but we can simultaneously use the types. That's what we did on e/e, see more discussion from me here on that e/e repo.

An addendum since that comment, it looks like there's a header that can be used to enable the issueType field in the GraphQL API, so there may be ways to access the types via the API, but it's not fully baked yet.

The main reason to leave the labels for now is to keep the Ecosystem WG Overview project tabs working, which filter based on labels. I tried to find a way to filter by either label or type, but no luck.

@erickzhao
Copy link
Member Author

Oops, I've been removing the labels as I go triaging older issues. I'll add them back as well and amend this PR. 🤦

@erickzhao erickzhao requested a review from dsanders11 February 8, 2025 05:32
@erickzhao erickzhao added this pull request to the merge queue Feb 8, 2025
Merged via the queue into main with commit 9edf547 Feb 8, 2025
12 checks passed
@erickzhao erickzhao deleted the chore/issue-templates branch February 8, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants