Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maker-flatpak): fix flatpakArch for arm64 #3839

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

pano9000
Copy link
Contributor

@pano9000 pano9000 commented Feb 6, 2025

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Hi,

this PR is a fix for the issue described in #3838
It fixes it by adding translating the "arm64" architecture string from electron-forge, into "aarch64", which is what Flatpak is actually expecting.
The same thing was done for "x64" and "x86_64" as well.

closes #3838

@pano9000 pano9000 requested a review from a team as a code owner February 6, 2025 19:41
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@erickzhao erickzhao added this pull request to the merge queue Feb 8, 2025
Merged via the queue into electron:main with commit 9e5633f Feb 8, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maker-flatpak: Building for arm64 is broken
2 participants