fix: quote filepath for Import-PfxCertificate #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing the dev certificate via `Import-PfxCertificate` requires the path to be quoted, otherwise installation fails if the path contains whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing the dev certificate via
Import-PfxCertificaterequires the path to be quoted, otherwise installation fails if the path contains whitespace.(That happened to me, changed it in my local
node_modulesand that fixed it.)I'm not sure what
pvk2pfx.exedoes and saw no more errors once I quotedpfxininstallPfxArgsso I left it at that – but maybe it needs to be quoted inpk2pfxArgstoo and I just didn't hit that code path?