Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change accessibility label #29

Merged
merged 1 commit into from
May 5, 2020
Merged

change accessibility label #29

merged 1 commit into from
May 5, 2020

Conversation

deepueg
Copy link
Collaborator

@deepueg deepueg commented May 5, 2020 •
edited
Loading

The API is referring the param name as adaLabel

@deepueg deepueg requested a review from asharpbflat May 5, 2020 18:04
@friederbluemle
Copy link
Member

@deepueg - Can you rebase please? There was an issue with a command on ci that I disabled in #28

@friederbluemle
Copy link
Member

Interesting btw.. what does "ada" mean? :P

@deepueg
Copy link
Collaborator Author

deepueg commented May 5, 2020

Interesting btw.. what does "ada" mean? :P

Americans with Disabilities Act (ADA), not the best choice for variable naming

@deepueg deepueg force-pushed the fix-ada-documentation branch from 32a64bd to f54cb48 Compare May 5, 2020 20:10
@deepueg deepueg force-pushed the fix-ada-documentation branch from f54cb48 to 7492721 Compare May 5, 2020 20:32
@deepueg deepueg merged commit b3063e6 into electrode-io:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friederbluemle friederbluemle friederbluemle approved these changes

@asharpbflat asharpbflat asharpbflat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepueg @friederbluemle @asharpbflat