Implementation of embedded client #2297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnetised
force-pushed
the
2256-add-embedded-client-implementation
branch
2 times, most recently
from
172076c to
def5564
Compare
magnetised
force-pushed
the
2256-add-embedded-client-implementation
branch
2 times, most recently
from
86fa1a4 to
d3fd28a
Compare
magnetised
force-pushed
the
2256-allow-for-a-pure-elixir-api
branch
from
ea6edeb to
c0e4d05
Compare
magnetised
force-pushed
the
2256-add-embedded-client-implementation
branch
4 times, most recently
from
d302051 to
71f6e0e
Compare
magnetised
force-pushed
the
2256-add-embedded-client-implementation
branch
2 times, most recently
from
78ce6d0 to
db7c4a3
Compare
which talks to electric over the internal api, not http
remove offsets from messages, add global lsn to up-to-date message and fix mock impl also validate column names from client are not empty
magnetised
force-pushed
the
2256-add-embedded-client-implementation
branch
from
53c5fa6 to
fa193d3
Compare
|
@msfstef just seen the failing tests. If you can review on the assumption I'll fix those, which are all about test configs lacking the new required persistent kv entry, then I'll fix when I'm back off hols . ta |
msfstef
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which talks to electric over the internal api, not http