fix: Do not await for responses when recovering pub filters #2265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
recover_shape
andrefresh_publication
are in theinit
path ofShapeCache
, and there is no reason why we would be waiting for responses.The
recover_shape
has no expected failure as it simply updates a map with appropriate counters.The
refresh_publication
will schedule a publication update, but we don't have to wait for it to finish to considerShapeCache
ready, as the shape consumers are already up and running and any new shapes will trigger another publication update after this one.These changes are based off of Sentry errors noticed from the cloud.
I've also set the publication update debounce time to 0ms, so now it simply waits until end of current process message queue. This addresses an unnecessary delay in
prepare_table
calls (@robacourt), since even when there is no contention it would still debounce for 50ms. I think that simply reinserting the update at the end of the message queue should still handle things pretty well but we can see the benchmarks.