Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hackathon participants add #671

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

schimih
Copy link
Contributor

@schimih schimih commented Nov 25, 2023

Added participants at xDay MultiversX Hackathon

Copy link
Contributor

@eherrerosj eherrerosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments

data/ecosystems/m/multiversx-elrond.toml Outdated Show resolved Hide resolved
data/ecosystems/m/multiversx-elrond.toml Outdated Show resolved Hide resolved
data/ecosystems/m/multiversx-elrond.toml Outdated Show resolved Hide resolved
data/ecosystems/m/multiversx-elrond.toml Outdated Show resolved Hide resolved
data/ecosystems/m/multiversx-elrond.toml Outdated Show resolved Hide resolved
data/ecosystems/m/multiversx-elrond.toml Outdated Show resolved Hide resolved
data/ecosystems/m/multiversx-elrond.toml Outdated Show resolved Hide resolved
data/ecosystems/m/multiversx-elrond.toml Outdated Show resolved Hide resolved
data/ecosystems/m/multiversx-elrond.toml Outdated Show resolved Hide resolved
data/ecosystems/m/multiversx-elrond.toml Outdated Show resolved Hide resolved
@eherrerosj eherrerosj added the waiting Waiting for requester to reply or do some improvements label Nov 28, 2023
@eherrerosj
Copy link
Contributor

There seems to be duplicate repos @schimih:
https://github.com/electric-capital/crypto-ecosystems/actions/runs/7078682275/job/19264432889?pr=671#step:5:55

Please make sure the validation step passes when you commit new changes

@schimih
Copy link
Contributor Author

schimih commented Dec 5, 2023

fixed. it was a "typo".

Copy link
Contributor

@eherrerosj eherrerosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thank you!

@eherrerosj eherrerosj merged commit e5c779a into electric-capital:master Dec 11, 2023
1 check passed
platonicsocrates pushed a commit to platonicsocrates/crypto-ecosystems that referenced this pull request Dec 23, 2023
* hackathon participants add

* fix after fail

* fixes after review

* fix after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting Waiting for requester to reply or do some improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants