-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added NodeKit #543
Added NodeKit #543
Conversation
@mtgnoah, any chance you'll be able to go through my suggestions within the next couple weeks? This way we can merge this PR and make the repo development count towards the 2023 Dev Report |
Hey just added and pushed it |
Hey @eherrerosj, if this PR looks good, could we please add it? Looks like @mtgnoah pushed some changes |
I'm seeing there's conflict happening in nodekit.toml @ashucoder9, @mtgnoah, could you fix it so I can merge? |
I guess only you and @mtgnoah have write access! |
I think I fixed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changed needed
Hi @ashucoder9, @mtgnoah, we wanted to give you a heads-up that we are planning to freeze the data set that will be used for the analysis during the next few days. If you want your changes to be included and have an impact on this year’s report, please ensure that the requested modifications are made and merged prior to the data freeze. Let's aim to have your PR finalized as soon as possible to make it into this window. If you have any questions or need further clarification, feel free to reply here or reach out directly. |
Hi @eherrerosj I think I have now made all the required changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. Thanks! Merging
* Added NodeKit * added * Update nodekit.toml * Update avalanche.toml * Update nodekit.toml
No description provided.