Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NodeKit #543

Merged
merged 6 commits into from
Dec 15, 2023
Merged

Added NodeKit #543

merged 6 commits into from
Dec 15, 2023

Conversation

mtgnoah
Copy link
Contributor

@mtgnoah mtgnoah commented Jul 11, 2023

No description provided.

@eherrerosj eherrerosj added the waiting Waiting for requester to reply or do some improvements label Nov 7, 2023
@eherrerosj
Copy link
Contributor

@mtgnoah, any chance you'll be able to go through my suggestions within the next couple weeks? This way we can merge this PR and make the repo development count towards the 2023 Dev Report

@mtgnoah
Copy link
Contributor Author

mtgnoah commented Nov 7, 2023

@mtgnoah, any chance you'll be able to go through my suggestions within the next couple weeks? This way we can merge this PR and make the repo development count towards the 2023 Dev Report

Hey just added and pushed it

@ashucoder9
Copy link
Contributor

Hey @eherrerosj, if this PR looks good, could we please add it? Looks like @mtgnoah pushed some changes

@eherrerosj
Copy link
Contributor

Hey @eherrerosj, if this PR looks good, could we please add it? Looks like @mtgnoah pushed some changes

I'm seeing there's conflict happening in nodekit.toml @ashucoder9, @mtgnoah, could you fix it so I can merge?

@ashucoder9
Copy link
Contributor

Hey @eherrerosj, if this PR looks good, could we please add it? Looks like @mtgnoah pushed some changes

I'm seeing there's conflict happening in nodekit.toml @ashucoder9, @mtgnoah, could you fix it so I can merge?

I guess only you and @mtgnoah have write access!

@mtgnoah
Copy link
Contributor Author

mtgnoah commented Nov 28, 2023

Hey @eherrerosj, if this PR looks good, could we please add it? Looks like @mtgnoah pushed some changes

I'm seeing there's conflict happening in nodekit.toml @ashucoder9, @mtgnoah, could you fix it so I can merge?

I think I fixed it

eherrerosj

This comment was marked as outdated.

Copy link
Contributor

@eherrerosj eherrerosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changed needed

@eherrerosj
Copy link
Contributor

Hi @ashucoder9, @mtgnoah, we wanted to give you a heads-up that we are planning to freeze the data set that will be used for the analysis during the next few days. If you want your changes to be included and have an impact on this year’s report, please ensure that the requested modifications are made and merged prior to the data freeze.

Let's aim to have your PR finalized as soon as possible to make it into this window. If you have any questions or need further clarification, feel free to reply here or reach out directly.

@mtgnoah
Copy link
Contributor Author

mtgnoah commented Dec 15, 2023

Hi @eherrerosj I think I have now made all the required changes.

Copy link
Contributor

@eherrerosj eherrerosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks! Merging

@eherrerosj eherrerosj merged commit 522cc63 into electric-capital:master Dec 15, 2023
1 check passed
platonicsocrates pushed a commit to platonicsocrates/crypto-ecosystems that referenced this pull request Dec 23, 2023
* Added NodeKit

* added

* Update nodekit.toml

* Update avalanche.toml

* Update nodekit.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting Waiting for requester to reply or do some improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants