refactor(versionCheck): add app data ready check condition

electh · Nov 26, 2024 · 90671b6 · 90671b6
1 parent fdfab6e
commit 90671b6
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/hooks/useVersionCheck.js b/src/hooks/useVersionCheck.js
@@ -1,11 +1,15 @@
+import { useStore } from "@nanostores/react"
 import { ofetch } from "ofetch"
 import { useEffect, useState } from "react"
 
+import { dataState } from "@/store/dataState"
 import { GITHUB_REPO_PATH, UPDATE_NOTIFICATION_KEY } from "@/utils/constants"
 import { checkIsInLast24Hours, getTimestamp } from "@/utils/date"
 import buildInfo from "@/version-info.json"
 
 function useVersionCheck() {
+  const { isAppDataReady } = useStore(dataState)
+
   const [hasUpdate, setHasUpdate] = useState(false)
 
   const dismissUpdate = () => {
@@ -14,7 +18,7 @@ function useVersionCheck() {
   }
 
   useEffect(() => {
-    if (!import.meta.env.PROD) {
+    if (!isAppDataReady || !import.meta.env.PROD) {
       return
     }
 
@@ -37,7 +41,7 @@ function useVersionCheck() {
     }
 
     checkUpdate()
-  }, [])
+  }, [isAppDataReady])
 
   return { hasUpdate, dismissUpdate }
 }