Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Added instructions for 3 nodes + kibana #586

Merged
merged 7 commits into from
Oct 30, 2019

Conversation

debadair
Copy link
Contributor

@debadair debadair commented Oct 8, 2019

Uses a compose file that launches 3 nodes + Kibana.

Related to #455

@debadair debadair added the WIP Work in progress label Oct 8, 2019
@debadair debadair changed the title [DOCS] Added instructions for 3 modes + kibana [DOCS] Added instructions for 3 nodes + kibana Oct 9, 2019
Copy link

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Left a few comments.

docs/en/getting-started/docker-compose.yml Outdated Show resolved Hide resolved
docs/en/getting-started/docker-compose.yml Outdated Show resolved Hide resolved
docs/en/getting-started/get-started-docker.asciidoc Outdated Show resolved Hide resolved
@jethr0null
Copy link

@fxdgear if you have a moment, would you mind giving this a look over as well?

@fxdgear
Copy link

fxdgear commented Oct 23, 2019

From just a quick glance nothing seems out of place.

I would ultimately recommend using "env" files for the envs for both the ssl'd versions and the non ssl'd versions this would allow for some de-duplication of work.

@debadair
Copy link
Contributor Author

From just a quick glance nothing seems out of place.

I would ultimately recommend using "env" files for the envs for both the ssl'd versions and the non ssl'd versions this would allow for some de-duplication of work.

While I agree this makes sense from a maintenance standpoint, my inclination is to keep the "basic" version as simple as possible.

@debadair debadair merged commit 6c93f79 into elastic:master Oct 30, 2019
debadair added a commit to debadair/stack-docs that referenced this pull request Oct 30, 2019
* Added instructions for 3 modes + kibana

* Added TLS section

* Incorporated review comments.
debadair added a commit to debadair/stack-docs that referenced this pull request Oct 30, 2019
* Added instructions for 3 modes + kibana

* Added TLS section

* Incorporated review comments.
debadair added a commit to debadair/stack-docs that referenced this pull request Oct 30, 2019
* Added instructions for 3 modes + kibana

* Added TLS section

* Incorporated review comments.
debadair added a commit that referenced this pull request Oct 30, 2019
* Added instructions for 3 modes + kibana

* Added TLS section

* Incorporated review comments.
debadair added a commit that referenced this pull request Oct 30, 2019
* Added instructions for 3 modes + kibana

* Added TLS section

* Incorporated review comments.
debadair added a commit that referenced this pull request Oct 30, 2019
* Added instructions for 3 modes + kibana

* Added TLS section

* Incorporated review comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants