Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] fixed bug in output secret diff logic #172081

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

juliaElastic
Copy link
Contributor

Summary

Related to #104986

Found a bug in diffOutputSecretPaths where output secret was deleted if updating an output without change of service_token. Added unit tests to cover the logic.

Steps to verify:

  • enable feature flags: xpack.fleet.enableExperimental: ['remoteESOutput', 'outputSecretsStorage']
  • create a remote es output with a service_token
  • check that the service_token is stored as secret in .fleet-secrets
  • update host in remote es output
  • verify that the secret is not deleted

Checklist

@juliaElastic juliaElastic added the release_note:skip Skip the PR/issue when compiling release notes label Nov 28, 2023
@juliaElastic juliaElastic self-assigned this Nov 28, 2023
@juliaElastic juliaElastic requested a review from a team as a code owner November 28, 2023 15:47
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 - always good when the PR is 90% tests 🙂

@juliaElastic juliaElastic enabled auto-merge (squash) November 29, 2023 08:48
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB +8.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

@juliaElastic juliaElastic merged commit 2ff6a7c into elastic:main Nov 29, 2023
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants