Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3379 lsp config documentation and gowork 2 #3397

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

kaanyalti
Copy link
Contributor

What is the problem this PR solves?

I was running into lsp errors while trying to work on e2e tests. The details of the errors are outlined in the PR itself. This made working on the testing package quite difficult as I was not getting any sort of completions or suggestions.

How does this PR solve the problem?

One of the errors was due to the nested modules. Configuring go workspaces resolves this issue. I configured go.work on my machine and tried to make it work with the build steps as can be seen in this PR; however, I couldn't resolve several issues. In this PR I added go.work and go.work.sum files to the .gitignore file and described how you can configure them. The second issue was due to the build constraints (eg. //go:build e2e). The solution for this is explained in the updated README.

How to test this PR locally

Please make sure that go.work configuration works for you. With the changes in this PR, confirm that you are still getting code suggestions/completions in all the modules in the repo.

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@kaanyalti kaanyalti requested a review from a team as a code owner March 22, 2024 23:05
@kaanyalti kaanyalti linked an issue Mar 22, 2024 that may be closed by this pull request
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding those LGTM 🚀

@kaanyalti kaanyalti force-pushed the 3379-lsp-config-documentation-and-gowork-2 branch from ed0d511 to b037c9d Compare March 25, 2024 17:33
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@kaanyalti kaanyalti merged commit e19e701 into main Mar 25, 2024
8 checks passed
@kaanyalti kaanyalti deleted the 3379-lsp-config-documentation-and-gowork-2 branch March 25, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSP config documentation and go.work
3 participants