Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use pinned versions #3168

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

v1v
Copy link
Member

@v1v v1v commented Dec 13, 2023

What is the problem this PR solves?

Use pinned version. Otherwise, if breaking changes in the upstream, it will affect the whole project.

It was reverted accidentally, see #3154 (comment)

How does this PR solve the problem?

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@v1v v1v added the backport-skip Skip notification from the automated backport with mergify label Dec 13, 2023
@v1v v1v requested a review from juliaElastic December 13, 2023 16:20
@v1v v1v self-assigned this Dec 13, 2023
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@juliaElastic juliaElastic merged commit d7c17c3 into elastic:8.12 Dec 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants