[TEST] Cover custom sorting and routing in randomized testing #120584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkrik-es
added
>test
kkrik-es
commented
Jan 22, 2025
| assertOK(response); | ||
| var responseBody = entityAsMap(response); | ||
| assertThat("errors in baseline bulk response:\n " + responseBody, responseBody.get("errors"), equalTo(false)); | ||
| return responseBody; | ||
| } |
There was a problem hiding this comment.
All this logic feels out of place here, specific to tests using bulk indexing.. It probably belongs more to a sibling of ReindexChallengeRestIT, like BulkChallengeRestIT. Thoughts?
There was a problem hiding this comment.
Went ahead with this refactoring, ptal.
… logsdb/random-test-routing
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires some refactoring due to the fact that, with routing on sort fields, ids are auto-generated. Since some tests compare base and contender results using doc ids, the auto-generated id from contender needs to be used when indexing docs on baseline side.
Related to #109334