Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x][Entitlements] Fix "No SecurityManager when entitlements are enabled" #119764

Conversation

ldematte
Copy link
Contributor

@ldematte ldematte commented Jan 8, 2025

Backport of #119742

breskeby and others added 30 commits December 18, 2024 00:13
) (elastic#118836)

We do not have SearchStats for fields from lookup indices. And unfortunately, these are hard to obtain.

For now, just do not apply ReplaceMissingFieldWithNull to fields coming from an index used in LOOKUP JOIN. These are identified via their indexmode.
Add section about removing index

Co-authored-by: Adam Szaraniec <[email protected]>
…8809)

* Fixing the string locale

* Missing a toUpper

(cherry picked from commit 5572777)

# Conflicts:
#	muted-tests.yml
…#118862)

Allow queries to succeed if some shards are failing
…0_metrics_ingest/Test metrics-apm.app-* setting event.ingested via ingest pipeline} elastic#118875
…ic#118879)

We are changing the format of an unreleased API in elastic#118803. This causes
yamlRestCompatTest to fail. This PR is commenting out the failed test
for now. Once elastic#118803 goes in, I'll backport the change and reenable
this test (with the new structure).
…st {p0=synonyms/90_synonyms_reloading_for_synset/Reload analyzers for specific synonym set} elastic#116777
…lastic#118744) (elastic#118884)

* [8.x] Add min. read-only index version compatible to DiscoveryNode (elastic#118744)

In a short future we'd like to use this information in methods like IndexMetadataVerifier#checkSupportedVersion and NodeJoineExecutor to allow opening indices in N-2 versions as read-only indices on ES V9.

* MINIMUM_READONLY_COMPATIBLE
… (elastic#118885)

This PR enables the resolution of field names containing "." after the rollover of the anomalies results index. This way, the object parts of the field name, e.g., for an influencer, will indeed have the object type and can be resolved in search and filter operations.
…lastic#118674) (elastic#118886)

In anomaly detection, score renormalization will update the anomaly score in the result indices. However, if the index in the old format was marked as read-only, the score update will fail. Since this failure is expected, this PR suppresses the error logging in this specific case.
resolves elastic#118476

This adds an implicit cast from string to date nanos, much the same as we do for millisecond dates. In the course of working on this, I found and fixed a couple of tests that were creating pre-epoch date nanos, which are not supported in elasticsearch. I also refactored the conversion code to use the standard DateUtils functions where appropriate, which caught some of the above errors in test data.
```
- class: org.elasticsearch.xpack.application.OpenAiServiceUpgradeIT
  method: testOpenAiEmbeddings {upgradedNodes=1}
  issue: elastic#118156
- class: org.elasticsearch.xpack.application.HuggingFaceServiceUpgradeIT
  method: testHFEmbeddings {upgradedNodes=1}
  issue: elastic#118197
- class: org.elasticsearch.xpack.application.OpenAiServiceUpgradeIT
  method: testOpenAiCompletions {upgradedNodes=2}
  issue: elastic#118163
- class: org.elasticsearch.xpack.application.OpenAiServiceUpgradeIT
  method: testOpenAiCompletions {upgradedNodes=1}
  issue: elastic#118162
- class: org.elasticsearch.xpack.application.HuggingFaceServiceUpgradeIT
  method: testElser {upgradedNodes=1}
  issue: elastic#118127
- class: org.elasticsearch.xpack.application.CohereServiceUpgradeIT
  method: testCohereEmbeddings {upgradedNodes=1}
  issue: elastic#116974
```
…t-only (elastic#118853)

* Mark the lookup join tests in IndexResolverFieldNamesTests as snapshot-only (elastic#118815)

(cherry picked from commit e0763c2)

* Unmute the sql test
This PR updates the Elasticsearch ILM tutorial for the newer screenshot
and the primary shard update in the text.

Co-authored-by: Satyam Mishra <[email protected]>
…o bfdeddb (elastic#118869)

Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>
…lastic#118544) (elastic#118918)

(cherry picked from commit 3f1fed0)

# Conflicts:
#	x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/LocalPhysicalPlanOptimizerTests.java
… time (elastic#118925)

Closes elastic#116777

This test failed on 8.x due to the inability to merge the backport for
elastic#118691 in 8.17
(elastic#118818) as it was blocked
by an unrelated test failure.
This change replaces the build with scope parameter in order to make
it cleaner when parameter is build and how it is used.

(cherry picked from commit b8f4677)
…astic#118854) (elastic#118928)

* Make ES|QL scoring tests running consistently in serverless (elastic#118854)

* make scoring tests running consistently in serverless

enforce _id in books dataset to make doc distribution across shards consistent.
books settings with 3 shards to accomodate serverless settings.
unmuting scoring tests.
scoring test fixed.

(cherry picked from commit 140beb1)
ldematte and others added 14 commits January 8, 2025 10:54
…ed when entitlements are enabled (elastic#119689)"

This reverts commit e4a4eb1.
…19690) (elastic#119695)

This change fixes the store option of the underlying sparse vector field for semantic text.
For legacy indices, the store option should remain false since changing this option on an existing index is not allowed and that term vectors are already stored in _source.
…lastic#119738)

* Add missing parameter to xpack.info rest-api-spec

* Update docs/changelog/118954.yaml
@ldematte ldematte added >non-issue :Core/Infra/Core Core issues without another label auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) v8.18.0 test-entitlements Trigger CI checks using security manager replacement labels Jan 8, 2025
@ldematte ldematte requested review from a team as code owners January 8, 2025 14:47
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team v9.0.0 labels Jan 8, 2025
@ldematte ldematte closed this Jan 8, 2025
@ldematte ldematte deleted the backport/8.x/entitlements/boostrap-disallow-sm-miss branch January 8, 2025 14:48
@ldematte ldematte restored the backport/8.x/entitlements/boostrap-disallow-sm-miss branch January 8, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team test-entitlements Trigger CI checks using security manager replacement v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.