Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump armsecurity #2450

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Bump armsecurity #2450

merged 5 commits into from
Sep 2, 2024

Conversation

romulets
Copy link
Member

Bump arm security and solve breaking changes.

The payload of arm security has changed from the previous version:

From

{
  "id": "/subscriptions/<subID>/providers/Microsoft.Security/securityContacts/default",
  "name": "default",
  "type": "Microsoft.Security/securityContacts",
  "properties": {
    "alertNotifications": {
      "state": "On",
      "minimalSeverity": "High"
    },
    "notificationsByRole": {
      "state": "On",
      "roles": [
        "Owner"
      ]
    },
    "emails": "...",
    "phone": ""
  }
}

to

{
  "id": "/subscriptions/<Your_Subscription_Id>/providers/Microsoft.Security/securityContact/default",
  "name": "default",
  "type": "Microsoft.Security/securityContact",
  "properties": {
    "notificationsByRole": {
      "state": "On",
      "roles": [
        "Owner",
        "Admin"
      ]
    },
    "isEnabled": true,
    "emails": "[email protected];[email protected]",
    "phone": "(214)275-4038",
    "notificationsSources": [
      {
        "sourceType": "AttackPath",
        "minimalRiskLevel": "Critical"
      },
      {
        "sourceType": "Alert",
        "minimalSeverity": "Medium"
      }
    ]
  }
}

There isn't however any docs on what is the migration path. Therefore I tested the UI and API and made a few assumptions.

Assumption 1:

We can't save the email settings without selecting Notify about alerts with the following severity (or higher):, therefore I assume the the default Notification Source with a valid level means that the notification is enabled
image

Assumption 2:
There is no clarity on what is the default notification source type. By testing, it seems to be Alert. I'm using it as the default.

Related issues

@romulets romulets requested a review from a team as a code owner August 23, 2024 10:24
Copy link

mergify bot commented Aug 23, 2024

This pull request does not have a backport label. Could you fix it @romulets? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@oren-zohar oren-zohar requested a review from moukoublen August 29, 2024 11:12
@romulets romulets enabled auto-merge (squash) September 2, 2024 13:22
@romulets romulets merged commit f126485 into elastic:main Sep 2, 2024
11 checks passed
@romulets romulets deleted the bump-armsecurity branch September 2, 2024 13:35
kubasobon pushed a commit to kubasobon/cloudbeat that referenced this pull request Sep 4, 2024
* Bump armsecurity

* Use official armsecurity contacts client
kubasobon pushed a commit to kubasobon/cloudbeat that referenced this pull request Sep 5, 2024
* Bump armsecurity

* Use official armsecurity contacts client
@kubasobon
Copy link
Member

Verified
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CIS AZURE][Dependency Lock] 2.1.20 List security contact data - payload changed
2 participants