Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hermit and pre-commit dependencies #2239

Merged
merged 1 commit into from
May 30, 2024

Conversation

moukoublen
Copy link
Member

Summary of your changes

Update hermit and pre-commit dependencies and exclude regal because of lint fixes that are required in the new release.

Screenshot/Data

Related Issues

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

Copy link
Contributor

@orestisfl orestisfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add the new regal rules to our ignored rule list?

@elastic elastic deleted a comment from mergify bot May 30, 2024
@moukoublen
Copy link
Member Author

@orestisfl We could do that in a separate pr; with a very quick search, the only way I found is to put # regal ignore:<rule> per file/entity, so it seems much quicker to handle it in a separate pr while merging the updates for the rest of the tools.

Copy link

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 314
⬜ Skipped 33

@moukoublen moukoublen merged commit cd2d4ba into elastic:main May 30, 2024
24 checks passed
@moukoublen moukoublen deleted the bump-tools branch May 30, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants