-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use substring check for EKS cluster name provider #2227
Use substring check for EKS cluster name provider #2227
Conversation
This pull request does not have a backport label. Could you fix it @therealdwright? 🙏
|
📊 Allure Report - 💚 No failures were reported.
|
Hello @therealdwright, and thanks for opening the issue and the PR, One minor concern: Would it be safer to compare using I am not sure if it's actually needed. I just thought of cases where tags could perhaps contain |
I think this is a fair criticism and I am only personally interested in ends with but was trying to be robust but happy to boil this one down to YAGNI. |
57e7511
to
88cea46
Compare
Karpenter managed clusters will use `aws:eks:cluster-name` for its cluster name tag. This commit updates the logic to use a substring check so both the existing tag of `eks:cluster-name` and karpenter are supported.
88cea46
to
d790e72
Compare
LGTM Thanks @therealdwright! |
Thanks @moukoublen - would you have any idea which elastic-agent release this will be in? |
@therealdwright most probably |
Summary of your changes
Karpenter managed clusters will use
aws:eks:cluster-name
for itscluster name tag. This commit updates the logic to use a substring
check so both the existing tag of
eks:cluster-name
and karpenterare supported.
Related Issues
Checklist