Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GCP credentials key extraction #2225

Merged
merged 3 commits into from
May 26, 2024
Merged

fix GCP credentials key extraction #2225

merged 3 commits into from
May 26, 2024

Conversation

orouz
Copy link
Collaborator

@orouz orouz commented May 23, 2024

Summary of your changes

@Omolola-Akinleye noticed the deployment script fails, and after taking a look in turns out the response we now get in gcloud shell is different so the key extraction (which is what failed) needs to be a little different.

Screenshot/Data

this is how it looks in gcloud shell after running the script:

Screenshot 2024-05-23 at 18 07 14

@mergify mergify bot assigned orouz May 23, 2024
Copy link

mergify bot commented May 23, 2024

This pull request does not have a backport label. Could you fix it @orouz? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

Copy link

github-actions bot commented May 23, 2024

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 359
⬜ Skipped 33

@orouz orouz marked this pull request as ready for review May 26, 2024 08:21
@orouz orouz requested a review from a team as a code owner May 26, 2024 08:21
@orouz orouz merged commit 45db84e into main May 26, 2024
26 checks passed
@orouz orouz deleted the gcp_sa branch May 26, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GCP] Automated credentials creation flow for agentless
2 participants