Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog: document apm_user role removal breaking change #15197

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

endorama
Copy link
Member

@endorama endorama commented Jan 9, 2025

Motivation/summary

Add a changelog entry for apm_user role removal, which is a breaking change affecting Tail Based Sampling.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

#14859

@endorama endorama requested a review from a team as a code owner January 9, 2025 16:42
@endorama endorama force-pushed the 9-changelog-apm_user-role branch from f036ecb to 78c2f5f Compare January 9, 2025 16:43
Copy link
Contributor

mergify bot commented Jan 9, 2025

This pull request does not have a backport label. Could you fix it @endorama? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

Copy link
Contributor

mergify bot commented Jan 9, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 9, 2025
@endorama endorama added backport-skip Skip notification from the automated backport with mergify and removed backport-8.x Automated backport to the 8.x branch with mergify labels Jan 9, 2025
Comment on lines +8 to +9
- Elasticsearch `apm_user` role has been removed. After this change additional permissions are required for Tail Based Sampling.
For more details, see https://github.com/elastic/apm-server/pull/14876[PR #14876]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this change additional permissions are required for Tail Based Sampling

I think the wording is a bit confusing 😓
The requirements for tbs didn't change. A user will have to specify permission manually if they are relying on apm_user but that would be implicit by Elasticsearch apm_user role has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants