Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove audio waveform background in dark mode #1119

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Remove audio waveform background in dark mode #1119

merged 1 commit into from
Sep 26, 2023

Conversation

LukasKalbertodt
Copy link
Member

Fixes #1096

CC @lkiesow

lkiesow
lkiesow approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@lkiesow lkiesow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that.

I would personally also go for a transparent background in light mode and make sure the actual waveform is dark, but this is definitely better than it was before.

Merging.

@lkiesow lkiesow merged commit f0b725c into elan-ev:master Sep 26, 2023
@LukasKalbertodt LukasKalbertodt deleted the improve-waveform-box-dark-mode branch September 27, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkiesow lkiesow lkiesow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Waveform appearance in dark mode
2 participants
@LukasKalbertodt @lkiesow