Revert "Add Buffer layer to outer service for efficiency" #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2de8333.
I didn't realize this, but the
Bufferlayer actually limits the concurrency of the inner service because semaphore permits are not dropped until the request actually finishes execution in the asynccall()handler of the inner service. This means that we started limiting concurrent connections drastically.In particular this broke sshx 9 hours ago for several users. Ahhh. At least I was running a lot of replicas around the world, which mitigated it a little.
Especially sorry to European users, who got eaten up by the German server, which has the most load.
If you're reading this and were affected, please report the bug next time something like this happens! (though it hopefully won't happen again) I'm glad I had monitoring. 😅